Format attributes on stmt and single line block #1814
Closed
+117
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks pretty easy to fix in libsyntax - I'm testing a PR at the moment, and hopefully that should land in a few days. Should we wait for that and land a 'nicer' version of this? Or just go ahead and land the current version? |
nrc
reviewed
Jul 24, 2017
| assert!( | ||
| !diff.is_empty(), | ||
| "Empty diff? Maybe due to a missing a newline at the end of a file?" | ||
| ); |
There was a problem hiding this comment.
This is a mistake, sorry.
|
I would rather wait until the rust-lang/rust#43463 lands and create a better PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation to format attributes on statements and single line block.
Closes #1813.
While trying to solve #1813, I found that rustfmt removes attributes on top of a single line block.
Unfortunately, since
dois not covered in the span from rust parser fordo catch, there are some dirty hacks when we must use span.